[cfe-commits] r68395 - in /cfe/trunk: lib/Parse/ParseDecl.cpp test/FixIt/fixit-objc.m

Chris Lattner sabre at nondot.org
Fri Apr 3 11:38:42 PDT 2009


Author: lattner
Date: Fri Apr  3 13:38:42 2009
New Revision: 68395

URL: http://llvm.org/viewvc/llvm-project?rev=68395&view=rev
Log:
add fixit advice to an archiac ObjC issue.

Added:
    cfe/trunk/test/FixIt/fixit-objc.m
Modified:
    cfe/trunk/lib/Parse/ParseDecl.cpp

Modified: cfe/trunk/lib/Parse/ParseDecl.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseDecl.cpp?rev=68395&r1=68394&r2=68395&view=diff

==============================================================================
--- cfe/trunk/lib/Parse/ParseDecl.cpp (original)
+++ cfe/trunk/lib/Parse/ParseDecl.cpp Fri Apr  3 13:38:42 2009
@@ -832,6 +832,7 @@
         DS.SetRangeEnd(EndProtoLoc);
 
         Diag(Loc, diag::warn_objc_protocol_qualifier_missing_id)
+          << CodeModificationHint::CreateInsertion(Loc, "id")
           << SourceRange(Loc, EndProtoLoc);
         // Need to support trailing type qualifiers (e.g. "id<p> const").
         // If a type specifier follows, it will be diagnosed elsewhere.

Added: cfe/trunk/test/FixIt/fixit-objc.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit-objc.m?rev=68395&view=auto

==============================================================================
--- cfe/trunk/test/FixIt/fixit-objc.m (added)
+++ cfe/trunk/test/FixIt/fixit-objc.m Fri Apr  3 13:38:42 2009
@@ -0,0 +1,8 @@
+// RUN: clang-cc -fsyntax-only -fixit-at=fixit-at.c:3:1 %s -o %t.m &&
+// RUN: clang-cc -verify %t.m
+
+ at protocol X;
+
+void foo() {
+  <X> *P;    // should be fixed to 'id<X>'.
+}





More information about the cfe-commits mailing list