[cfe-commits] r68267 - in /cfe/trunk: include/clang/Basic/LangOptions.h include/clang/Driver/Options.def lib/CodeGen/CGExprScalar.cpp tools/clang-cc/clang-cc.cpp
Mike Stump
mrs at apple.com
Wed Apr 1 18:03:55 PDT 2009
Author: mrs
Date: Wed Apr 1 20:03:55 2009
New Revision: 68267
URL: http://llvm.org/viewvc/llvm-project?rev=68267&view=rev
Log:
Fixup -ftrapv to be more gcc compatible. -ftrapu (for want of a
better name) is the option that SmallTalk can use to intercept all
overflows, including unsigned. I added some testcases so we don't
break anything.
Also included is another patch from David for += and friends.
Modified:
cfe/trunk/include/clang/Basic/LangOptions.h
cfe/trunk/include/clang/Driver/Options.def
cfe/trunk/lib/CodeGen/CGExprScalar.cpp
cfe/trunk/tools/clang-cc/clang-cc.cpp
Modified: cfe/trunk/include/clang/Basic/LangOptions.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/LangOptions.h?rev=68267&r1=68266&r2=68267&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/LangOptions.h (original)
+++ cfe/trunk/include/clang/Basic/LangOptions.h Wed Apr 1 20:03:55 2009
@@ -59,8 +59,12 @@
unsigned MathErrno : 1; // Math functions must respect errno
// (modulo the platform support).
+ unsigned UnsignedOverflowChecking : 1;
+ // Extension to call a handler function when
+ // unsigned and signed integer arithmetic overflows.
+
unsigned OverflowChecking : 1; // Extension to call a handler function when
- // integer arithmetic overflows.
+ // signed integer arithmetic overflows.
unsigned HeinousExtensions : 1; // Extensions that we really don't like and
// may be ripped out at any time.
@@ -90,6 +94,7 @@
EmitAllDecls = 0;
MathErrno = 1;
+ UnsignedOverflowChecking = 0;
OverflowChecking = 0;
InstantiationDepth = 99;
Modified: cfe/trunk/include/clang/Driver/Options.def
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.def?rev=68267&r1=68266&r2=68267&view=diff
==============================================================================
--- cfe/trunk/include/clang/Driver/Options.def (original)
+++ cfe/trunk/include/clang/Driver/Options.def Wed Apr 1 20:03:55 2009
@@ -448,6 +448,7 @@
OPTION("-fterminated-vtables", fterminated_vtables, Flag, f_Group, INVALID, "", 0, 0, 0)
OPTION("-ftime-report", ftime_report, Flag, clang_f_Group, INVALID, "", 0, 0, 0)
OPTION("-ftraditional", ftraditional, Flag, f_Group, INVALID, "", 0, 0, 0)
+OPTION("-ftrapu", ftrapu, Flag, clang_f_Group, INVALID, "", 0, 0, 0)
OPTION("-ftrapv", ftrapv, Flag, clang_f_Group, INVALID, "", 0, 0, 0)
OPTION("-funwind-tables", funwind_tables, Flag, f_Group, INVALID, "", 0, 0, 0)
OPTION("-fverbose-asm", fverbose_asm, Flag, f_Group, INVALID, "", 0, 0, 0)
Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=68267&r1=68266&r2=68267&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGExprScalar.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGExprScalar.cpp Wed Apr 1 20:03:55 2009
@@ -262,7 +262,9 @@
// Binary Operators.
Value *EmitMul(const BinOpInfo &Ops) {
- if (CGF.getContext().getLangOptions().OverflowChecking)
+ if (CGF.getContext().getLangOptions().UnsignedOverflowChecking
+ || (CGF.getContext().getLangOptions().OverflowChecking
+ && Ops.Ty->isSignedIntegerType()))
return EmitOverflowCheckedBinOp(Ops);
return Builder.CreateMul(Ops.LHS, Ops.RHS, "mul");
}
@@ -834,21 +836,26 @@
Value *ScalarExprEmitter::EmitOverflowCheckedBinOp(const BinOpInfo &Ops) {
unsigned IID;
unsigned OpID = 0;
+
if (Ops.Ty->isSignedIntegerType()) {
switch (Ops.E->getOpcode()) {
case BinaryOperator::Add:
+ case BinaryOperator::AddAssign:
OpID = 1;
IID = llvm::Intrinsic::sadd_with_overflow;
break;
case BinaryOperator::Sub:
+ case BinaryOperator::SubAssign:
OpID = 2;
IID = llvm::Intrinsic::ssub_with_overflow;
break;
case BinaryOperator::Mul:
+ case BinaryOperator::MulAssign:
OpID = 3;
IID = llvm::Intrinsic::smul_with_overflow;
break;
default:
+ fprintf(stderr, "Opcode: %d\n", Ops.E->getOpcode());
assert(false && "Unsupported operation for overflow detection");
}
OpID <<= 1;
@@ -859,14 +866,17 @@
"Must be either a signed or unsigned integer op");
switch (Ops.E->getOpcode()) {
case BinaryOperator::Add:
+ case BinaryOperator::AddAssign:
OpID = 1;
IID = llvm::Intrinsic::uadd_with_overflow;
break;
case BinaryOperator::Sub:
+ case BinaryOperator::SubAssign:
OpID = 2;
IID = llvm::Intrinsic::usub_with_overflow;
break;
case BinaryOperator::Mul:
+ case BinaryOperator::MulAssign:
OpID = 3;
IID = llvm::Intrinsic::umul_with_overflow;
break;
@@ -935,7 +945,9 @@
Value *ScalarExprEmitter::EmitAdd(const BinOpInfo &Ops) {
if (!Ops.Ty->isPointerType()) {
- if (CGF.getContext().getLangOptions().OverflowChecking)
+ if (CGF.getContext().getLangOptions().UnsignedOverflowChecking
+ || (CGF.getContext().getLangOptions().OverflowChecking
+ && Ops.Ty->isSignedIntegerType()))
return EmitOverflowCheckedBinOp(Ops);
return Builder.CreateAdd(Ops.LHS, Ops.RHS, "add");
}
@@ -986,7 +998,9 @@
Value *ScalarExprEmitter::EmitSub(const BinOpInfo &Ops) {
if (!isa<llvm::PointerType>(Ops.LHS->getType())) {
- if (CGF.getContext().getLangOptions().OverflowChecking)
+ if (CGF.getContext().getLangOptions().UnsignedOverflowChecking
+ || (CGF.getContext().getLangOptions().OverflowChecking
+ && Ops.Ty->isSignedIntegerType()))
return EmitOverflowCheckedBinOp(Ops);
return Builder.CreateSub(Ops.LHS, Ops.RHS, "sub");
}
Modified: cfe/trunk/tools/clang-cc/clang-cc.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-cc/clang-cc.cpp?rev=68267&r1=68266&r2=68267&view=diff
==============================================================================
--- cfe/trunk/tools/clang-cc/clang-cc.cpp (original)
+++ cfe/trunk/tools/clang-cc/clang-cc.cpp Wed Apr 1 20:03:55 2009
@@ -676,12 +676,18 @@
}
static llvm::cl::opt<bool>
+UnsignedOverflowChecking("ftrapu",
+ llvm::cl::desc("Trap on unsigned and signed integer overflow"),
+ llvm::cl::init(false));
+
+static llvm::cl::opt<bool>
OverflowChecking("ftrapv",
- llvm::cl::desc("Trap on integer overflow"),
+ llvm::cl::desc("Trap on signed integer overflow"),
llvm::cl::init(false));
void InitializeOverflowChecking(LangOptions &Options) {
- Options.OverflowChecking = OverflowChecking;
+ Options.OverflowChecking = OverflowChecking | UnsignedOverflowChecking;
+ Options.UnsignedOverflowChecking = UnsignedOverflowChecking;
}
//===----------------------------------------------------------------------===//
// Target Triple Processing.
More information about the cfe-commits
mailing list