[cfe-commits] r67429 - /cfe/trunk/lib/CodeGen/Mangle.cpp

[Chris Lattner]

On Mar 21, 2009, at 2:21 AM, Cédric Venet wrote:

> Chris Lattner a écrit :
>> Author: lattner
>> Date: Sat Mar 21 01:19:20 2009
>> New Revision: 67429
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=67429&view=rev
>> Log:
>> simplify CXXNameMangler::mangle, making it exit earlier for C  
>> functions.
>> This speeds up a testcase in 3810 by ~16%.
>>
>>
>
> On windows, function name are 'mangled' by prefixing the name with  
> an underscore or arobase and depending to the calling convention  
> suffixed with the size of the arguments. Should this be done here?

No, this should be done by the llvm code generator.

> ps: should the list have a reply-to:cfe-commits at cs.uiuc.edu? Like it  
> is actually, it is easy to reply only to the sender.

I don't have a strong opinion on this either way.

-Chris