[cfe-commits] r67295 - in /cfe/trunk: include/clang/Driver/Compilation.h lib/Driver/Compilation.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Thu Mar 19 03:01:45 2009
New Revision: 67295

URL: http://llvm.org/viewvc/llvm-project?rev=67295&view=rev
Log:
Driver: Executing piped jobs with a single command is easy.

Modified:
    cfe/trunk/include/clang/Driver/Compilation.h
    cfe/trunk/lib/Driver/Compilation.cpp

Modified: cfe/trunk/include/clang/Driver/Compilation.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Compilation.h?rev=67295&r1=67294&r2=67295&view=diff

==============================================================================
--- cfe/trunk/include/clang/Driver/Compilation.h (original)
+++ cfe/trunk/include/clang/Driver/Compilation.h Thu Mar 19 03:01:45 2009
@@ -109,6 +109,11 @@
   void PrintJob(llvm::raw_ostream &OS, const Job &J, 
                 const char *Terminator, bool Quote) const;
 
+  /// ExecuteCommand - Execute an actual command.
+  ///
+  /// \return The result code of the subprocess.
+  int ExecuteCommand(const Command &C) const;
+
   /// ExecuteJob - Execute a single job.
   ///
   /// \return The accumulated result code of the job.

Modified: cfe/trunk/lib/Driver/Compilation.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Compilation.cpp?rev=67295&r1=67294&r2=67295&view=diff

==============================================================================
--- cfe/trunk/lib/Driver/Compilation.cpp (original)
+++ cfe/trunk/lib/Driver/Compilation.cpp Thu Mar 19 03:01:45 2009
@@ -108,32 +108,39 @@
   return Success;
 }
 
+int Compilation::ExecuteCommand(const Command &C) const {
+  llvm::sys::Path Prog(C.getExecutable());
+  const char **Argv = new const char*[C.getArguments().size() + 2];
+  Argv[0] = C.getExecutable();
+  std::copy(C.getArguments().begin(), C.getArguments().end(), Argv+1);
+  Argv[C.getArguments().size() + 1] = 0;
+  
+  if (getDriver().CCCEcho || getArgs().hasArg(options::OPT_v))
+    PrintJob(llvm::errs(), C, "\n", false);
+    
+  std::string Error;
+  int Res = 
+    llvm::sys::Program::ExecuteAndWait(Prog, Argv,
+                                       /*env*/0, /*redirects*/0,
+                                       /*secondsToWait*/0, /*memoryLimit*/0,
+                                       &Error);
+  if (!Error.empty()) {
+    assert(Res && "Error string set with 0 result code!");
+    getDriver().Diag(clang::diag::err_drv_command_failure) << Error;
+  }
+  
+  delete[] Argv;
+  return Res;
+}
+
 int Compilation::ExecuteJob(const Job &J) const {
   if (const Command *C = dyn_cast<Command>(&J)) {
-    llvm::sys::Path Prog(C->getExecutable());
-    const char **Argv = new const char*[C->getArguments().size() + 2];
-    Argv[0] = C->getExecutable();
-    std::copy(C->getArguments().begin(), C->getArguments().end(), Argv+1);
-    Argv[C->getArguments().size() + 1] = 0;
-
-    if (getDriver().CCCEcho || getArgs().hasArg(options::OPT_v))
-      PrintJob(llvm::errs(), J, "\n", false);
-    
-    std::string Error;
-    int Res = 
-      llvm::sys::Program::ExecuteAndWait(Prog, Argv,
-                                         /*env*/0, /*redirects*/0,
-                                         /*secondsToWait*/0, /*memoryLimit*/0,
-                                         &Error);
-    if (!Error.empty()) {
-      assert(Res && "Error string set with 0 result code!");
-      getDriver().Diag(clang::diag::err_drv_command_failure) << Error;
-    }
-    
-    delete[] Argv;
-    return Res;
+    return ExecuteCommand(*C);
   } else if (const PipedJob *PJ = dyn_cast<PipedJob>(&J)) {
-    (void) PJ;
+    // Piped commands with a single job are easy.
+    if (PJ->size() == 1)
+      return ExecuteCommand(**PJ->begin());
+      
     getDriver().Diag(clang::diag::err_drv_unsupported_opt) << "-pipe";
     return 1;
   } else {