[cfe-commits] r67204 - in /cfe/trunk/lib/Driver: Driver.cpp Makefile

[Daniel Dunbar]

On Wed, Mar 18, 2009 at 10:34 AM, Mike Stump <mrs at apple.com> wrote:

> On Mar 18, 2009, at 10:06 AM, Daniel Dunbar wrote:
>
>> This isn't right; the Driver library shouldn't have these things embedded
>> in it. The reason I left it blank was because I was going to do try and
>> provide a proper version number derived from SVN (at some point).
>>
>
> Derived how?  During the build, there isn't necessarily any svn there, so
> one cannot use svn in any way to derive it.  One can use the various LLVM
> #defines, but these don't include the tag information when someone builds a
> non-standard tag and I would like to have that tag information.  Anyway, I
> didn't see any constructive criticism about what you saw and what you would
> rather see instead.  Currently it prints something like:
>
> ccc version 1.0 (http://llvm.org/svn/llvm-project/cfe/trunk)
>
> which I think is fine.  If someone tags clang, say for an llvm release, it
> will have the release tag.  If we want to add the svn revision information,
> a la gcc, we could do that, but it is a harder to get at and isn't always
> available (svn export say).
>

Yes, this is what I meant.


>
>  Also, the use of TARGET_TRIPLE isn't necessary; the Driver already knows
>> what host it is on (DefaultHostTriple),
>>
>
> Yeah, the only problem with that is I don't actually want to print the host
> information.  Now, if you had DefaultTargetTriple, that would be closer to
> what I'd want.
>

The default tool chain has this information (in pieces currently, I will
probably introduce an explicit Triple object at some point); it can be
accessed through the Compilation structure.

 - Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20090318/8702fe9d/attachment.html>