[cfe-commits] r66010 - /cfe/trunk/lib/CodeGen/CGDecl.cpp

[Eli Friedman]

Author: efriedma
Date: Tue Mar  3 22:22:58 2009
New Revision: 66010

URL: http://llvm.org/viewvc/llvm-project?rev=66010&view=rev
Log:
Comment fix: change a question to an answer.


Modified:
    cfe/trunk/lib/CodeGen/CGDecl.cpp

Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDecl.cpp?rev=66010&r1=66009&r2=66010&view=diff

==============================================================================
--- cfe/trunk/lib/CodeGen/CGDecl.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGDecl.cpp Tue Mar  3 22:22:58 2009
@@ -127,11 +127,9 @@
         GenerateStaticCXXBlockVarDeclInit(D, GV);
     } else {
       // The initializer may differ in type from the global. Rewrite
-      // the global to match the initializer!?
-      //
-      // FIXME: This matches what we have been doing historically, but
-      // it seems bad. Shouldn't the init expression have the right
-      // type?
+      // the global to match the initializer.  (We have to do this
+      // because some types, like unions, can't be completely represented
+      // in the LLVM type system.)
       if (GV->getType() != Init->getType()) {
         llvm::GlobalVariable *OldGV = GV;