[cfe-commits] r65746 - in /cfe/trunk: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGExprConstant.cpp lib/CodeGen/CodeGenFunction.h test/CodeGen/blocks.c

Mike Stump mrs at apple.com
Sun Mar 1 10:51:02 PST 2009


On Feb 28, 2009, at 5:09 PM, Anders Carlsson wrote:
> +  // Check if the block can be global.
> +  if (CanBlockBeGlobal(Info))
> +    return CGM.GetAddrOfGlobalBlock(BE, Name.c_str());

Like the last change, this also breaks things that were working.  :- 
(  Please, monotonic improvements only please.  We lazily create  
imports during codegen and your code doesn't account for that.



More information about the cfe-commits mailing list