[cfe-commits] r65510 - /cfe/trunk/lib/CodeGen/CGCall.cpp

[Chris Lattner]

On Feb 26, 2009, at 1:34 AM, Eli Friedman wrote:

> On Wed, Feb 25, 2009 at 11:21 PM, Daniel Dunbar <daniel at zuster.org>  
> wrote:
>>   } else if (Ty->isPointerLikeType() || Ty->isBlockPointerType() ||
>> +             Ty->isObjCQualifiedIdType() ||
>>              Ty->isObjCQualifiedInterfaceType()) {
>
> It's getting to the point where we use the pattern isPointer ||
> isBlockPointer || isObjCQualId || isObjCQualInterface in a lot of
> places, and are using incomplete versions of it in a lot of others.
> Maybe a new predicate would be appropriate?

Maybe block pointers and objc qualified id's and qualified interfaces  
should inherit from PointerLikeType?  Then we could use  
isPointerLikeType?

-Chris