[cfe-commits] r65381 - in /cfe/trunk: lib/CodeGen/CGExprConstant.cpp test/CodeGen/const-init.c

[Eli Friedman]

On Tue, Feb 24, 2009 at 10:41 AM, Daniel Dunbar <daniel at zuster.org> wrote:
> +        // We can never refer to a variable with local storage.
> +        if (!VD->hasLocalStorage()) {

This should be an assertion, no?

> +// RUN: grep '@g18.p = internal global \[1 x i32\*\] \[i32\* @g19\]' %t &&
> +// FIXME: Should we really accept this in Sema?

Why shouldn't we accept it?

> +void g18(void) {
> +  extern int g19;
> +  static int *p[] = { &g19 };
> +}

-Eli