[cfe-commits] r65244 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Type.h lib/AST/ASTContext.cpp lib/AST/Type.cpp lib/Sema/SemaType.cpp test/SemaObjC/protocol-archane.m

[Chris Lattner]

>>>>
>>>> Will never be seen in user code. Needed to pass dejagnu testsuite.
>>>
>>> So... why do we care? Why not just keep this unsupported? Or at
>>> least,
>>> warn about it?
>>>
>>
>> I'm in a conforming mood:-)
>>
>> Kidding aside, I'm fine with not supporting it. I'd really like to
>> avoid gratuitous changes to the type system like this.
>>
>> I'd like Chris and Fariborz to weigh in before I revert any  
>> changes...
>
> If you are confident that there is no real use for it, then let's
> remove this change and
> issue an error instead. I have seen a few dejagnu tests, but they
> could just be test coverage.

Can you guys explain why this is horrible to someone not very familiar  
with ObjC?

Unlike with C, I'm of the opinion that clang should clamp down on some  
of the obscure ObjC GCC-isms that should never have be allowed in the  
first place.  For better or worse, Clang's ObjC support is what people  
will have to deal with in the future, and now is the time to get it  
"right".

If we do reject this, we should emit a error that is 1) really good  
and 2) explains that this is an intentional divergence from GCC, not a  
bug in clang.

-Chris