[cfe-commits] r64969 - /cfe/trunk/lib/CodeGen/CodeGenModule.cpp

Daniel Dunbar daniel at zuster.org
Wed Feb 18 14:52:09 PST 2009

Author: ddunbar
Date: Wed Feb 18 16:52:09 2009
New Revision: 64969

URL: http://llvm.org/viewvc/llvm-project?rev=64969&view=rev
Add anti-FIXME.


Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=64969&r1=64968&r2=64969&view=diff

--- cfe/trunk/lib/CodeGen/CodeGenModule.cpp (original)
+++ cfe/trunk/lib/CodeGen/CodeGenModule.cpp Wed Feb 18 16:52:09 2009
@@ -162,7 +162,10 @@
 /// FIXME: Returning an IdentifierInfo* here is a total hack. We
 /// really need some kind of string abstraction that either stores a
 /// mangled name or stores an IdentifierInfo*. This will require
-/// changes to the GlobalDeclMap, too.
+/// changes to the GlobalDeclMap, too. (I disagree, I think what we
+/// actually need is for Sema to provide some notion of which Decls
+/// refer to the same semantic decl. We shouldn't need to mangle the
+/// names and see what comes out the same to figure this out. - DWD)
 /// FIXME: Performance here is going to be terribly until we start
 /// caching mangled names. However, we should fix the problem above

More information about the cfe-commits mailing list