[cfe-commits] r64478 - in /cfe/trunk: include/clang/AST/Attr.h include/clang/Parse/AttributeList.h lib/Parse/AttributeList.cpp lib/Sema/SemaDeclAttr.cpp test/Sema/attr-used.c

[Daniel Dunbar]

Author: ddunbar
Date: Fri Feb 13 13:23:53 2009
New Revision: 64478

URL: http://llvm.org/viewvc/llvm-project?rev=64478&view=rev
Log:
Sema/AST support for attribute used. Patch by Anders Johnson (with small tweaks & test case)!

Added:
    cfe/trunk/test/Sema/attr-used.c
Modified:
    cfe/trunk/include/clang/AST/Attr.h
    cfe/trunk/include/clang/Parse/AttributeList.h
    cfe/trunk/lib/Parse/AttributeList.cpp
    cfe/trunk/lib/Sema/SemaDeclAttr.cpp

Modified: cfe/trunk/include/clang/AST/Attr.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Attr.h?rev=64478&r1=64477&r2=64478&view=diff

==============================================================================
--- cfe/trunk/include/clang/AST/Attr.h (original)
+++ cfe/trunk/include/clang/AST/Attr.h Fri Feb 13 13:23:53 2009
@@ -50,6 +50,7 @@
     TransparentUnion,
     Unavailable,
     Unused,    
+    Used,
     Visibility,
     Weak,
     Blocks,
@@ -266,6 +267,15 @@
   static bool classof(const UnusedAttr *A) { return true; }
 };  
   
+class UsedAttr : public Attr {
+public:
+  UsedAttr() : Attr(Used) {}
+  
+  // Implement isa/cast/dyncast/etc.
+  static bool classof(const Attr *A) { return A->getKind() == Used; }  
+  static bool classof(const UsedAttr *A) { return true; }
+};  
+  
 class WeakAttr : public Attr {
 public:
   WeakAttr() : Attr(Weak) {}

Modified: cfe/trunk/include/clang/Parse/AttributeList.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Parse/AttributeList.h?rev=64478&r1=64477&r2=64478&view=diff

==============================================================================
--- cfe/trunk/include/clang/Parse/AttributeList.h (original)
+++ cfe/trunk/include/clang/Parse/AttributeList.h Fri Feb 13 13:23:53 2009
@@ -70,6 +70,7 @@
     AT_transparent_union,
     AT_unavailable,
     AT_unused,
+    AT_used,
     AT_vector_size,
     AT_visibility,
     AT_warn_unused_result,

Modified: cfe/trunk/lib/Parse/AttributeList.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/AttributeList.cpp?rev=64478&r1=64477&r2=64478&view=diff

==============================================================================
--- cfe/trunk/lib/Parse/AttributeList.cpp (original)
+++ cfe/trunk/lib/Parse/AttributeList.cpp Fri Feb 13 13:23:53 2009
@@ -56,6 +56,7 @@
     if (!memcmp(Str, "weak", 4)) return AT_weak;
     if (!memcmp(Str, "pure", 4)) return AT_pure;
     if (!memcmp(Str, "mode", 4)) return AT_mode;
+    if (!memcmp(Str, "used", 4)) return AT_used;
     break;
   case 5:
     if (!memcmp(Str, "alias", 5)) return AT_alias;

Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclAttr.cpp?rev=64478&r1=64477&r2=64478&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclAttr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclAttr.cpp Fri Feb 13 13:23:53 2009
@@ -431,6 +431,27 @@
   d->addAttr(new UnusedAttr());
 }
 
+static void HandleUsedAttr(Decl *d, const AttributeList &Attr, Sema &S) {
+  // check the attribute arguments.
+  if (Attr.getNumArgs() != 0) {
+    S.Diag(Attr.getLoc(), diag::err_attribute_wrong_number_arguments) << 0;
+    return;
+  }
+  
+  if (const VarDecl *VD = dyn_cast<VarDecl>(d)) {
+    if (VD->hasLocalStorage()) {
+      S.Diag(Attr.getLoc(), diag::warn_attribute_ignored) << "used";
+      return;
+    }
+  } else if (!isFunctionOrMethod(d)) {
+    S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type)
+      << "used" << "variable and function";
+    return;
+  }
+  
+  d->addAttr(new UsedAttr());
+}
+
 static void HandleConstructorAttr(Decl *d, const AttributeList &Attr, Sema &S) {
   // check the attribute arguments.
   if (Attr.getNumArgs() != 0 && Attr.getNumArgs() != 1) {
@@ -1357,6 +1378,7 @@
   case AttributeList::AT_stdcall:     HandleStdCallAttr   (D, Attr, S); break;
   case AttributeList::AT_unavailable: HandleUnavailableAttr(D, Attr, S); break;
   case AttributeList::AT_unused:      HandleUnusedAttr    (D, Attr, S); break;
+  case AttributeList::AT_used:        HandleUsedAttr      (D, Attr, S); break;
   case AttributeList::AT_vector_size: HandleVectorSizeAttr(D, Attr, S); break;
   case AttributeList::AT_visibility:  HandleVisibilityAttr(D, Attr, S); break;
   case AttributeList::AT_weak:        HandleWeakAttr      (D, Attr, S); break;

Added: cfe/trunk/test/Sema/attr-used.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/attr-used.c?rev=64478&view=auto

==============================================================================
--- cfe/trunk/test/Sema/attr-used.c (added)
+++ cfe/trunk/test/Sema/attr-used.c Fri Feb 13 13:23:53 2009
@@ -0,0 +1,17 @@
+// RUN: clang -verify -fsyntax-only %s
+
+struct __attribute__((used)) s { // expected-warning {{'used' attribute only applies to variable and function types}}
+  int x;
+};
+
+int a __attribute__((used));
+
+static void __attribute__((used)) f0(void) {
+}
+
+void f1() {
+  static int a __attribute__((used)); 
+  int b __attribute__((used)); // expected-warning {{used attribute ignored}}
+}
+
+