[cfe-commits] RangeConstraintManager
Ted Kremenek
kremenek at apple.com
Fri Feb 13 11:05:47 PST 2009
On Feb 13, 2009, at 9:01 AM, Ben Laurie wrote:
>>>
>>> void Profile(llvm::FoldingSetNodeID &ID) const {
>>> ranges.Profile(ID);
>>> ID.AddBoolean(noValues);
>>> }
>>
>> Looks great.
>
> As previously discussed, though, "Profile" is a really bad name for
> this function!
I agree. Feel free to discuss this on llvmdev, as it is part of the
interface for FoldingSet. Alternatively one can define a
FoldingSetTrait<> class that uses a different method to get the hash.
More information about the cfe-commits
mailing list