[cfe-commits] RangeConstraintManager

[Sebastian Redl]

Ben Laurie wrote:
> On Thu, Feb 12, 2009 at 10:29 PM, Ted Kremenek <kremenek at apple.com> wrote:
>   
>> On Feb 12, 2009, at 5:15 AM, Ben Laurie wrote:
>>     
>   
>>> typedef llvm::ImmutableSet<Range> PrimRangeSet;
>>>       
>> Looks good.  Note that ImmutableSet uses the trait class 'ImutContainerInfo'
>> to compare items in the set.  The default implementation of
>> ImutContainerInfo uses std::less to compare items.  More info in
>> ImmutableSet.h (the default trait implementations are at the bottom of the
>> file, right before the declaration of 'class ImmutableSet'.  If things are
>> working correctly, you might need to migrate your logic from RangeCmp over a
>> ImutContainerInfo<Range> class
>>     
>
> I wonder what std::less does on a std::pair?
>
>   

return lhs.first < rhs.first || (!(rhs.first < lhs.first) && lhs.second
< rhs.second);

As per C++ 20.2.2p6.

Sebastian