[cfe-commits] r64271 - /cfe/trunk/tools/ccc/ccclib/Driver.py

[Mike Stump]

On Feb 10, 2009, at 5:32 PM, Daniel Dunbar wrote:
> Mike,
>
>> +        vers = '$HeadURL$'
>> +        vers = vers.split('/tools/ccc')[0]
>> +        vers = ' (' + vers[10:] + ')'
>> +        print >>sys.stderr,'ccc version 1.0' + vers
>
> I think:
> --
> vers = '$Rev$'
> vers = vers.split(':',1)[1].strip()
> print >>sys.stderr,'ccc version 1.0 (%s)' % vers
> --
> does the same thing more simply & robustly.

No, that does something completely different and unrelated.

> However, I have real doubts this is the way we want to go; I don't
> think using the svn keyword for this is appropriate. It will only
> change when Driver.py changes, and that will hopefully become fairly
> uncorrelated to the clang tree revision.

And this is exactly was I didn't use Rev.  Mine prints branches/ 
release_26, should llvm release clang with llvm for 2.6, and trunk for  
a trunk compiler.  For now, that's good enough.  If people tag it as  
dib-5432 for example, it prints dib-5432.  This is a tag version  
number, not a revision version number.