[cfe-commits] Declarator::getSourceRange()

[Chris Lattner]

On Feb 9, 2009, at 10:16 AM, Sebastian Redl wrote:
>>>> Does it make sense to just leave it as 'invalid'?
>>>
>>> No, this leads to extremely subtle bugs in error reporting, if  
>>> something
>>> then decides to actually use the source range. The location info
>>> isn't as
>>> fake as the comment makes it seem.
>>
>> What is a sensible location for a declspec that doesn't exist (e.g.
>> implicit int)?  Shouldn't any diagnostics relating to empty declspecs
>> be pointing to the decl itself?
> Of course it should. I've updated the comment to more clearly say  
> what's
> going on. I've also hunted down the implicit int case and made it  
> behave
> correctly.

Thanks Sebastian!

-Chris