[cfe-commits] r64196 - /cfe/trunk/include/clang/AST/Type.h

Chris Lattner clattner at apple.com
Mon Feb 9 21:01:15 PST 2009


Does this code really need to use CHAR_BIT here?  LLVM has many  
assumptions that it is running on a system with 8-bit bytes.  I don't  
think there is any reason to generalize beyond that.

-Chris

On Feb 9, 2009, at 6:14 PM, Argiris Kirtzidis wrote:

> Author: akirtzidis
> Date: Mon Feb  9 20:14:34 2009
> New Revision: 64196
>
> URL: http://llvm.org/viewvc/llvm-project?rev=64196&view=rev
> Log:
> Bring in 'CHAR_BIT' for GCC 4.3.
>
> Modified:
>    cfe/trunk/include/clang/AST/Type.h
>
> Modified: cfe/trunk/include/clang/AST/Type.h
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Type.h?rev=64196&r1=64195&r2=64196&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- cfe/trunk/include/clang/AST/Type.h (original)
> +++ cfe/trunk/include/clang/AST/Type.h Mon Feb  9 20:14:34 2009
> @@ -20,6 +20,7 @@
> #include "llvm/ADT/FoldingSet.h"
> #include "llvm/ADT/PointerIntPair.h"
> #include "llvm/Bitcode/SerializationFwd.h"
> +#include <climits>
> using llvm::isa;
> using llvm::cast;
> using llvm::cast_or_null;
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list