[cfe-commits] r63983 - in /cfe/trunk: include/clang/AST/Expr.h include/clang/AST/StmtVisitor.h include/clang/Basic/DiagnosticSemaKinds.def lib/AST/Expr.cpp lib/Parse/ParseExpr.cpp lib/Sema/Sema.h lib/Sema/SemaExpr.cpp lib/Sema/SemaInherit.h lib/Sema/SemaLookup.cpp test/SemaCXX/member-pointer.cpp www/cxx_status.html

[Chris Lattner]

On Feb 7, 2009, at 10:54 AM, Sebastian Redl wrote:
>>>> On Feb 6, 2009, at 4:15 PM, Sebastian Redl wrote:
>>>>
>>>>> +++ cfe/trunk/lib/Sema/SemaExpr.cpp Fri Feb  6 18:15:38 2009
>>>>> +
>>>>> +inline QualType Sema::CheckPointerToMemberOperands(
>>>>> +  Expr *&lex, Expr *&rex, SourceLocation Loc, bool isIndirect)
>>>>> +{
>>>>
>>>> Should this go in SemaExprCXX?
>>> I put it there at first, but these are all inline, so it wouldn't  
>>> link.
>>> Besides, it's a helper of CreateBuiltinBinOp, so it's probably  
>>> better to
>>> group it with all its siblings.
>>
>> Why does this need to be inline?
> Consistency with the other operand checkers. :-)

Heh, they probably shouldn't be inline either :)

-Chris