[cfe-commits] r63849 - /cfe/trunk/lib/Basic/Targets.cpp
Chris Lattner
clattner at apple.com
Thu Feb 5 09:43:47 PST 2009
On Feb 5, 2009, at 12:54 AM, Eli Friedman wrote:
> On Wed, Feb 4, 2009 at 11:32 PM, Chris Lattner <sabre at nondot.org>
> wrote:
>> + Define(Defs, "__SSE3__");
>
> We shouldn't be setting this unconditionally for x86-64; not all
> x86-64 chips have SSE3.
I agree, but we already have other problems in that file (e.g.
unconditionally claiming all x86-32 chips have sse2). Until we have
proper subtarget info there, I'm just going to go for consistency with
apple gcc 4.2 so that I can diff the output. Does that seem reasonable?
-Chris
More information about the cfe-commits
mailing list