[cfe-commits] r63683 - /cfe/trunk/lib/CodeGen/CGObjC.cpp

Daniel Dunbar daniel at zuster.org
Tue Feb 3 15:43:59 PST 2009


Author: ddunbar
Date: Tue Feb  3 17:43:59 2009
New Revision: 63683

URL: http://llvm.org/viewvc/llvm-project?rev=63683&view=rev
Log:
Fix return type for calls to objc_setProperty.

Modified:
    cfe/trunk/lib/CodeGen/CGObjC.cpp

Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjC.cpp?rev=63683&r1=63682&r2=63683&view=diff

==============================================================================
--- cfe/trunk/lib/CodeGen/CGObjC.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGObjC.cpp Tue Feb  3 17:43:59 2009
@@ -183,6 +183,8 @@
     Args.push_back(std::make_pair(RValue::get(CmdVal), Cmd->getType()));
     Args.push_back(std::make_pair(RValue::get(Offset), getContext().LongTy));
     Args.push_back(std::make_pair(RValue::get(True), getContext().BoolTy));
+    // FIXME: We shouldn't need to get the function info here, the
+    // runtime already should have computed it to build the function.
     RValue RV = EmitCall(Types.getFunctionInfo(PD->getType(), Args), 
                          GetPropertyFn, Args);
     // We need to fix the type here. Ivars with copy & retain are
@@ -269,7 +271,9 @@
                                   getContext().BoolTy));
     Args.push_back(std::make_pair(RValue::get(IsCopy ? True : False), 
                                   getContext().BoolTy));
-    EmitCall(Types.getFunctionInfo(PD->getType(), Args), 
+    // FIXME: We shouldn't need to get the function info here, the
+    // runtime already should have computed it to build the function.
+    EmitCall(Types.getFunctionInfo(getContext().VoidTy, Args), 
              SetPropertyFn, Args);
   } else {
     SourceLocation Loc = PD->getLocation();





More information about the cfe-commits mailing list