[cfe-commits] r63519 - in /cfe/trunk: lib/Sema/SemaDecl.cpp test/Sema/static-init.c

Nuno Lopes nunoplopes at sapo.pt
Mon Feb 2 15:01:26 PST 2009


>> -      if (!Base)
>> -        return CheckAddressConstantExpression(SubExpr);
>> +      return Base ? false : CheckAddressConstantExpression(SubExpr);
>>     }
>
> If you're going to add an ugly hack, please add a FIXME as well.

pardon my ignorance, but why is that such a horrible hack? As far as I can 
tell it makes sense..


>> +union bar u[1];
>> +struct foo x = {(int) u}; // no-error
>
> This test should fail on 64-bit targets... at a minimum, I'd suggest a
> FIXME.

OK, fixed!

Thanks,
Nuno 




More information about the cfe-commits mailing list