[cfe-commits] Patch to do static analysis with range sets

[Ben Laurie]

On Tue, Feb 3, 2009 at 5:47 AM, Ted Kremenek <kremenek at apple.com> wrote:
> Hi Ben,
>
> Thanks for tackling this!  I just started looking at this patch.  Since its
> a moderately sized patch it may take me a little time to review it
> carefully, but I'll try and give you some precise feedback shortly.
>
> One high-level comment: please put this logic in a new ConstraintManager.  I
> don't want to add this functionality to BasicConstraintManager for two
> reasons:
>
> (1) BasicConstraintManager, as limited as it is, is a stable baseline for
> the analyzer.
>
> (2) Having a different ConstraintManager for range analysis allows us to
> compare the time complexity vs. precision tradeoff we get between
> BasicConstraintManager and (say) RangesConstraintManager.  It also allows us
> to compare results, allowing us to cross-check each one for bugs.

Will do.

>
> Cheers,
> Ted
>
> On Feb 1, 2009, at 12:06 AM, Ben Laurie wrote:
>
>> Not complete - no self-tests and full of diagnostics, but I'd love to
>> get comments about the approach. Also hints on implementing tests (Ted
>> told me in IM, but I forgot), and how to preserve/add more debugging
>> stuff in an approved way, since I find that this stuff hurts my head
>> without it...
>>
>> Also, I have cases which fail because higher-level stuff seems to be
>> doing the wrong thing, but not sure how to go about debugging the rest
>> of static analysis...
>> <clang.patch>_______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>