[cfe-commits] r63264 - /cfe/trunk/lib/AST/ExprConstant.cpp

[Daniel Dunbar]

I believe you; I was just trying to get the minimum support so that I
could actually test results to look at ABI compatibility.

I think longer term we should pull out APComplexInt and APComplexFloat
classes which embed the correct semantics.

Please file bugs w/ test cases of any issues you are aware of.

- Daniel

On Thu, Jan 29, 2009 at 12:17 PM, Neil Booth <neil at daikokuya.co.uk> wrote:
> Daniel Dunbar wrote:-
>
>> Author: ddunbar
>> Date: Wed Jan 28 19:32:56 2009
>> New Revision: 63264
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=63264&view=rev
>> Log:
>> Add folding for complex mul and fix some major bugs in complex float
>> evaluation (alternate part of real/imag init was being set to 3 not 0
>> because the wrong APFloat constructor was being called).
>>  - Test cases coming once some more support is in.
>
> Of course, this code is not ideal, since e.g. it overflows unnecessarily
> in many cases, and rounds incorrectly in 50% (?) of cases.
>
> Neil.
>