[cfe-commits] r63242 - in /cfe/trunk: Driver/RewriteObjC.cpp include/clang/AST/Decl.h include/clang/AST/Expr.h include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.def lib/AST/Expr.cpp lib/AST/StmtPrinter.cpp lib/CodeGen/CGExprAgg.cpp lib/CodeGen/CGExprConstant.cpp lib/CodeGen/CGExprScalar.cpp lib/Sema/Sema.h lib/Sema/SemaDecl.cpp lib/Sema/SemaExpr.cpp lib/Sema/SemaInit.cpp test/Sema/array-init.c test/Sema/designated-initializers.c test/Sema/vector-init.c

[Douglas Gregor]

On Jan 29, 2009, at 10:48 AM, Chris Lattner wrote:

>
> On Jan 29, 2009, at 8:09 AM, Douglas Gregor wrote:
>
>>> Very nice Doug, please make these errors though.  Some code bases  
>>> build with many warnings, so this can be easy to miss.  Thanks for  
>>> working on this!
>>
>>
>> FWIW, follow-on patches (one still to-be-finished) get this down to  
>> only a very minor difference that we warn about (different behavior  
>> when GNU array-range designated initializers have side effects).
>
> I'm still not very comfortable about only warning about cases where  
> we miscompile the code.  The "different behavior" really is a  
> miscompilation in my opinion, do you agree?


Yes, it's a miscompilation. I'll make this an "unsupported" error in  
CodeGen, so that semantic clients aren't affected.

	- Doug