[cfe-commits] r63141 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

Fariborz Jahanian fjahanian at apple.com
Tue Jan 27 14:27:57 PST 2009


Author: fjahanian
Date: Tue Jan 27 16:27:56 2009
New Revision: 63141

URL: http://llvm.org/viewvc/llvm-project?rev=63141&view=rev
Log:
After talking to our runtime guru, I added a comment.

Modified:
    cfe/trunk/lib/CodeGen/CGObjCMac.cpp

Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjCMac.cpp?rev=63141&r1=63140&r2=63141&view=diff

==============================================================================
--- cfe/trunk/lib/CodeGen/CGObjCMac.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGObjCMac.cpp Tue Jan 27 16:27:56 2009
@@ -3562,6 +3562,11 @@
                        Field->getType().getTypePtr()) >> 3;
     Align = llvm::Log2_32(Align);
     Ivar[3] = llvm::ConstantInt::get(ObjCTypes.IntTy, Align);
+    // NOTE. Size of a bitfield does not match gcc's, because of the way
+    // bitfields are treated special in each. But I am told that 'size'
+    // for bitfield ivars is ignored by the runtime so it does not matter.
+    // (even if it matters, some day, there is enough info. to get the bitfield
+    // right!
     Ivar[4] = llvm::ConstantInt::get(ObjCTypes.IntTy, Size);
     Ivars.push_back(llvm::ConstantStruct::get(ObjCTypes.IvarnfABITy, Ivar));
   }





More information about the cfe-commits mailing list