[cfe-commits] r62947 - in /cfe/trunk: lib/Sema/SemaDecl.cpp test/Sema/decl-type-merging.c

[Eli Friedman]

Author: efriedma
Date: Sat Jan 24 17:49:55 2009
New Revision: 62947

URL: http://llvm.org/viewvc/llvm-project?rev=62947&view=rev
Log:
Fix for PR2100: merge types for variables.


Added:
    cfe/trunk/test/Sema/decl-type-merging.c
Modified:
    cfe/trunk/lib/Sema/SemaDecl.cpp

Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDecl.cpp?rev=62947&r1=62946&r2=62947&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaDecl.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDecl.cpp Sat Jan 24 17:49:55 2009
@@ -658,15 +658,15 @@
 
   MergeAttributes(New, Old);
 
-  // Verify the types match.
-  QualType OldCType = Context.getCanonicalType(Old->getType());
-  QualType NewCType = Context.getCanonicalType(New->getType());
-  if (OldCType != NewCType && !Context.typesAreCompatible(OldCType, NewCType)) {
+  // Merge the types
+  QualType MergedT = Context.mergeTypes(New->getType(), Old->getType());
+  if (MergedT.isNull()) {
     Diag(New->getLocation(), diag::err_redefinition_different_type) 
       << New->getDeclName();
     Diag(Old->getLocation(), diag::note_previous_definition);
     return New;
   }
+  New->setType(MergedT);
   // C99 6.2.2p4: Check if we have a static decl followed by a non-static.
   if (New->getStorageClass() == VarDecl::Static &&
       (Old->getStorageClass() == VarDecl::None ||

Added: cfe/trunk/test/Sema/decl-type-merging.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/decl-type-merging.c?rev=62947&view=auto

==============================================================================
--- cfe/trunk/test/Sema/decl-type-merging.c (added)
+++ cfe/trunk/test/Sema/decl-type-merging.c Sat Jan 24 17:49:55 2009
@@ -0,0 +1,16 @@
+// RUN: clang -fsyntax-only -std=c99 -verify -pedantic %s
+
+int x[10];
+int x[] = {1,2,3};
+int testx[(sizeof(x) == sizeof(int) * 10) ? 1 : -1];
+
+int (*a)(int (*x)[10], int (*y)[]);
+int (*a)(int (*x)[], int (*y)[5]);
+int b() {
+int x[10], y[5];
+a(&x, &y);
+a(&y, &y); // expected-warning {{incompatible pointer}}
+a(&x, &x); // expected-warning {{incompatible pointer}}
+}
+
+