[cfe-commits] r62771 - /cfe/trunk/lib/Analysis/SymbolManager.cpp

[Ted Kremenek]

Author: kremenek
Date: Thu Jan 22 12:51:33 2009
New Revision: 62771

URL: http://llvm.org/viewvc/llvm-project?rev=62771&view=rev
Log:
SymbolReaper::isLive(SymbolRef) now always returns true for SymbolRegionRvalues because these represent the symbolic values for parameters/globals upon entry to the function.  These values are always ;live' because they represent constraints on the context of how the function was called.  This will be useful for both summary generation but is also necessary to get RegionStore's lazy-binding of locations to symbols to work in practice with RemoveDeadBindings.

Modified:
    cfe/trunk/lib/Analysis/SymbolManager.cpp

Modified: cfe/trunk/lib/Analysis/SymbolManager.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/SymbolManager.cpp?rev=62771&r1=62770&r2=62771&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/SymbolManager.cpp (original)
+++ cfe/trunk/lib/Analysis/SymbolManager.cpp Thu Jan 22 12:51:33 2009
@@ -92,6 +92,11 @@
 }
 
 bool SymbolReaper::isLive(SymbolRef sym) {
-  return TheLiving.contains(sym);
+  if (TheLiving.contains(sym))
+    return true;
+  
+  // Interogate the symbol.  It may derive from an input value to
+  // the analyzed function/method.
+  return isa<SymbolRegionRValue>(SymMgr.getSymbolData(sym));
 }