[cfe-commits] r62703 - /cfe/trunk/lib/CodeGen/CGObjCGNU.cpp

[Chris Lattner]

On Jan 21, 2009, at 4:21 PM, David Chisnall wrote:

> On 21 Jan 2009, at 19:38, Chris Lattner wrote:
>
>>
>> On Jan 21, 2009, at 11:22 AM, Daniel Dunbar wrote:
>>
>>> codegen-gnu.m is failing on Darwin as of this commit, I believe.
>>
>> Thanks, I reverted the patch.  The type of selector was 'opaque'  
>> not a struct.
>
> The type of the selector will only be opaque if you have not  
> included the objc header - I thought we were okay with requiring  
> this, since all Objective-C programs do.  Apparently not though,  
> since this test doesn't include it.  I've updated the diff to  
> provide a special case for when the SEL type is an opaque pointer.   
> Any type other than this and a structure should be caught by Sema  
> before it gets this far.

Please don't use tabs.  Also, please use if (x == 0) instead of if (0  
== x).  Please declare SelectorTy as llvm::PointerType since it always  
must be a pointer.

Also, as a separate patch I see you use " (*iter).sec" in other parts  
of the code, please convert these to iter->sec.

-Chris