[cfe-commits] r62475 - in /cfe/trunk: Driver/PrintParserCallbacks.cpp include/clang/Parse/Action.h lib/Parse/ParseExpr.cpp lib/Parse/ParseStmt.cpp lib/Sema/Sema.h lib/Sema/SemaChecking.cpp lib/Sema/SemaExpr.cpp lib/Sema/SemaOverload.cpp

[Douglas Gregor]

On Jan 21, 2009, at 2:05 PM, Fariborz Jahanian wrote:

>
> On Jan 21, 2009, at 1:56 PM, Daniel Dunbar wrote:
>
>> Ok. Are you able/willing to investigate or should I try to con  
>> someone
>> else into it?
>>
>> - Daniel
>>
>> On Wed, Jan 21, 2009 at 1:33 PM, Sebastian Redl
>> <sebastian.redl at getdesigned.at> wrote:
>>> Daniel Dunbar wrote:
>>>> My performance tester is pointing at this for a 2.5% regression in
>>>> syntax only time.  Is this inherent and the price we have to pay  
>>>> for
>>>> cleanup, or unexpected?
>>>>
>>>>
>>> Unexpected. I do some very rough performance testing on every  
>>> bunch I
>>> convert and never notice a slowdown. There is an inherent price (the
>>> smart pointers carry around a pointer to the Action all the time),
>>> but I
>>> expected it to be unnoticeable.
>
> I thought the plan was to be able to #ifdef out smart pointers so we
> could measure
> its impact at given any time.

Yes, definitely. We just haven't done that work yet.

	- Doug