[cfe-commits] r62609 - in /cfe/trunk: include/clang/Basic/DiagnosticKinds.def lib/Sema/SemaStmt.cpp test/Sema/asm.c

[Anders Carlsson]

Author: andersca
Date: Tue Jan 20 14:49:22 2009
New Revision: 62609

URL: http://llvm.org/viewvc/llvm-project?rev=62609&view=rev
Log:
Improvements to Sema of asm statements. Fixes <rdar://problem/6156893>

Modified:
    cfe/trunk/include/clang/Basic/DiagnosticKinds.def
    cfe/trunk/lib/Sema/SemaStmt.cpp
    cfe/trunk/test/Sema/asm.c

Modified: cfe/trunk/include/clang/Basic/DiagnosticKinds.def
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticKinds.def?rev=62609&r1=62608&r2=62609&view=diff

==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticKinds.def (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticKinds.def Tue Jan 20 14:49:22 2009
@@ -1466,10 +1466,12 @@
     "invalid lvalue in asm output")
 DIAG(err_asm_invalid_output_constraint, ERROR,
     "invalid output constraint '%0' in asm")
+DIAG(err_asm_invalid_lvalue_in_input, ERROR,
+     "invalid lvalue in asm input for constraint '%0'")
 DIAG(err_asm_invalid_input_constraint, ERROR,
-    "invalid input constraint '%0' in asm")
+     "invalid input constraint '%0' in asm")
 DIAG(err_asm_invalid_type_in_input, ERROR,
-    "invalid type %0 in asm input for constraint '%1'")
+     "invalid type %0 in asm input for constraint '%1'")
 DIAG(err_asm_unknown_register_name, ERROR,
     "unknown register name '%0' in asm")
 DIAG(err_invalid_conversion_between_vectors, ERROR,

Modified: cfe/trunk/lib/Sema/SemaStmt.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaStmt.cpp?rev=62609&r1=62608&r2=62609&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaStmt.cpp (original)
+++ cfe/trunk/lib/Sema/SemaStmt.cpp Tue Jan 20 14:49:22 2009
@@ -896,18 +896,27 @@
                   diag::err_asm_invalid_input_constraint) << InputConstraint);
     }
 
-    // Check that the input exprs aren't of type void.
     ParenExpr *InputExpr = cast<ParenExpr>(Exprs[i]);
-    if (InputExpr->getType()->isVoidType()) {
 
-      return StmtError(Diag(InputExpr->getSubExpr()->getLocStart(),
-                  diag::err_asm_invalid_type_in_input)
-        << InputExpr->getType() << InputConstraint
-        << InputExpr->getSubExpr()->getSourceRange());
+    // Only allow void types for memory constraints.
+    if (info & TargetInfo::CI_AllowsMemory) {
+
+      if (InputExpr->isLvalue(Context) != Expr::LV_Valid)
+        return StmtError(Diag(InputExpr->getSubExpr()->getLocStart(),
+                              diag::err_asm_invalid_lvalue_in_input)
+          << InputConstraint << InputExpr->getSubExpr()->getSourceRange());
     }
 
-    if (info & TargetInfo::CI_AllowsRegister)
+    if (info & TargetInfo::CI_AllowsRegister) {
+      if (InputExpr->getType()->isVoidType()) {
+        return StmtError(Diag(InputExpr->getSubExpr()->getLocStart(),
+                              diag::err_asm_invalid_type_in_input)
+          << InputExpr->getType() << InputConstraint 
+          << InputExpr->getSubExpr()->getSourceRange());
+      }
+      
       DefaultFunctionArrayConversion(Exprs[i]);
+    }
   }
 
   // Check that the clobbers are valid.

Modified: cfe/trunk/test/Sema/asm.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/asm.c?rev=62609&r1=62608&r2=62609&view=diff

==============================================================================
--- cfe/trunk/test/Sema/asm.c (original)
+++ cfe/trunk/test/Sema/asm.c Tue Jan 20 14:49:22 2009
@@ -37,3 +37,14 @@
   asm("foo" : L"=r"(x)); // expected-error {{wide string}}
 }
 
+// <rdar://problem/6156893>
+void test4(const volatile void *addr)
+{
+    asm ("nop" : : "r"(*addr)); // expected-error {{invalid type 'void const volatile' in asm input for constraint 'r'}}
+    asm ("nop" : : "m"(*addr));
+
+    asm ("nop" : : "r"(test4(addr))); // expected-error {{invalid type 'void' in asm input for constraint 'r'}}
+    asm ("nop" : : "m"(test4(addr))); // expected-error {{invalid lvalue in asm input for constraint 'm'}}
+
+    asm("nop" : : "m"(f())); // expected-error {{invalid lvalue in asm input for constraint 'm'}}
+}