[cfe-commits] r62517 - in /cfe/trunk: Makefile tools/ccc/Makefile tools/ccc/ccc tools/ccc/xcc

Mike Stump mrs at apple.com
Mon Jan 19 16:37:29 PST 2009


On Jan 19, 2009, at 2:36 PM, Daniel Dunbar wrote:
> I cannot reproduce this. Can you send me a log of 'make -p install  
> VERBOSE=1'?

I find it easier to just fix it.

Also, wildcard doesn't do vpath processing.  The below fixes it.

Also, we need time timestamp and the real install directory location  
to ensure the that we get the same output reliably.

Ok?

Doing diffs in .:
--- tools/ccc/Makefile.~1~	2009-01-19 11:55:30.000000000 -0800
+++ tools/ccc/Makefile	2009-01-19 16:35:43.000000000 -0800
@@ -13,16 +13,16 @@ include $(LEVEL)/Makefile.common

  install-local:: $(PROJ_bindir)/ccc $(PROJ_bindir)/ccclib

-Extra := $(wildcard ccclib/*.py)
+Extra := $(wildcard $(PROJ_SRC_ROOT)/tools/clang/tools/ccc/ccclib/*.py)

  $(PROJ_bindir)/ccclib : $(Extra)
  	$(Echo) Installing ccclib.
-	$(Verb) mkdir -p $(PROJ_bindir)/ccclib
-	$(Verb) cp $? $(PROJ_bindir)/ccclib
-	$(Verb) python -m compileall $(PROJ_bindir)/ccclib
-	$(Verb) touch $(PROJ_bindir)/ccclib
+	$(Verb) mkdir -p "$(PROJ_bindir)/ccclib"
+	$(Verb) cp -p $? "$(PROJ_bindir)/ccclib"
+	$(Verb) python -m compileall -d "$(PROJ_prefix)/bin/ccclib" "$ 
(PROJ_bindir)/ccclib"
+	$(Verb) touch "$(PROJ_bindir)/ccclib"

  $(PROJ_bindir)/ccc : ccc
  	$(Echo) Installing $< shell script.
-	$(Verb) cat $< > $@
-	$(Verb) chmod 0755 $@
+	$(Verb) cat $< > "$@"
+	$(Verb) chmod 0755 "$@"
--------------



More information about the cfe-commits mailing list