[cfe-commits] r62431 - in /cfe/trunk: include/clang/Basic/DiagnosticKinds.def lib/Sema/SemaDeclObjC.cpp test/SemaObjC/method-bad-param.m

[Fariborz Jahanian]

Author: fjahanian
Date: Sat Jan 17 15:57:49 2009
New Revision: 62431

URL: http://llvm.org/viewvc/llvm-project?rev=62431&view=rev
Log:
Diagnose when method parameter is an object.


Added:
    cfe/trunk/test/SemaObjC/method-bad-param.m
Modified:
    cfe/trunk/include/clang/Basic/DiagnosticKinds.def
    cfe/trunk/lib/Sema/SemaDeclObjC.cpp

Modified: cfe/trunk/include/clang/Basic/DiagnosticKinds.def
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticKinds.def?rev=62431&r1=62430&r2=62431&view=diff

==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticKinds.def (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticKinds.def Sat Jan 17 15:57:49 2009
@@ -416,6 +416,8 @@
      "expected string literal or '[' for asm operand")
 DIAG(err_expected_selector_for_method, ERROR,
      "expected selector for Objective-C method")
+DIAG(err_object_as_method_param, ERROR,
+     "can not use an object as parameter to a method")
 DIAG(err_nsobject_attribute, ERROR,
      "__attribute ((NSObject)) is for pointer types only")
 

Modified: cfe/trunk/lib/Sema/SemaDeclObjC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclObjC.cpp?rev=62431&r1=62430&r2=62431&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclObjC.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclObjC.cpp Sat Jan 17 15:57:49 2009
@@ -1349,6 +1349,11 @@
       }
       else if (argType->isFunctionType())
         argType = Context.getPointerType(argType);
+      else if (argType->isObjCInterfaceType()) {
+        // FIXME! provide more precise location for the parameter
+        Diag(MethodLoc, diag::err_object_as_method_param);
+        return 0;
+      }
     } else
       argType = Context.getObjCIdType();
     ParmVarDecl* Param;

Added: cfe/trunk/test/SemaObjC/method-bad-param.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/method-bad-param.m?rev=62431&view=auto

==============================================================================
--- cfe/trunk/test/SemaObjC/method-bad-param.m (added)
+++ cfe/trunk/test/SemaObjC/method-bad-param.m Sat Jan 17 15:57:49 2009
@@ -0,0 +1,18 @@
+// RUN: clang -fsyntax-only -verify %s
+
+ at interface foo
+ at end
+
+ at implementation foo
+ at end
+
+ at interface bar
+-(void) my_method:(foo) my_param; // expected-error {{can not use an object as parameter to a method}}
+ at end
+
+ at implementation bar
+-(void) my_method:(foo) my_param  // expected-error {{can not use an object as parameter to a method}}
+{
+}
+ at end
+