[cfe-commits] r61937 - /cfe/trunk/lib/Sema/SemaDeclObjC.cpp
Steve Naroff
snaroff at apple.com
Thu Jan 8 12:17:35 PST 2009
Author: snaroff
Date: Thu Jan 8 14:17:34 2009
New Revision: 61937
URL: http://llvm.org/viewvc/llvm-project?rev=61937&view=rev
Log:
Move FIXME to a better location.
Modified:
cfe/trunk/lib/Sema/SemaDeclObjC.cpp
Modified: cfe/trunk/lib/Sema/SemaDeclObjC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclObjC.cpp?rev=61937&r1=61936&r2=61937&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclObjC.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclObjC.cpp Thu Jan 8 14:17:34 2009
@@ -1038,6 +1038,11 @@
// Synthesize getter/setter methods if none exist.
// Find the default getter and if one not found, add one.
+ // FIXME: The synthesized property we set here is misleading. We
+ // almost always synthesize these methods unless the user explicitly
+ // provided prototypes (which is odd, but allowed). Sema should be
+ // typechecking that the declarations jive in that situation (which
+ // it is not currently).
if (!GetterMethod) {
// No instance method of same name as property getter name was found.
// Declare a getter method and add it to the list of methods
@@ -1097,11 +1102,6 @@
// double bar = [foo bar];
// }
//
- // FIXME: The synthesized property we set here is misleading. We
- // almost always synthesize these methods unless the user explicitly
- // provided prototypes (which is odd, but allowed). Sema should be
- // typechecking that the declarations jive in that situation (which
- // it is not currently).
if (GetterMethod) {
CD->addDecl(Context, GetterMethod);
AddInstanceMethodToGlobalPool(GetterMethod);
More information about the cfe-commits
mailing list