[cfe-commits] r61800 - /cfe/trunk/lib/Sema/SemaDeclCXX.cpp

Chris Lattner sabre at nondot.org
Mon Jan 5 23:24:29 PST 2009


Author: lattner
Date: Tue Jan  6 01:24:29 2009
New Revision: 61800

URL: http://llvm.org/viewvc/llvm-project?rev=61800&view=rev
Log:
it is ok to insert empty source ranges into diagnostics, declare variable in an if.

Modified:
    cfe/trunk/lib/Sema/SemaDeclCXX.cpp

Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclCXX.cpp?rev=61800&r1=61799&r2=61800&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclCXX.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclCXX.cpp Tue Jan  6 01:24:29 2009
@@ -1448,14 +1448,11 @@
   // FIXME: This still requires lot more checks, and AST support.
   // Lookup namespace name.
   DeclContext *DC = static_cast<DeclContext*>(SS.getScopeRep());
-  Decl *NS = 0;
 
-  if ((NS = LookupNamespaceName(NamespcName, S, DC))) {
+  if (Decl *NS = LookupNamespaceName(NamespcName, S, DC)) {
     assert(isa<NamespaceDecl>(NS) && "expected namespace decl");
   } else {
-    DiagnosticBuilder Builder = Diag(IdentLoc, diag::err_expected_namespace_name);
-    if (SS.isSet())
-      Builder << SS.getRange();
+    Diag(IdentLoc, diag::err_expected_namespace_name) << SS.getRange();
   }
 
   // FIXME: We ignore AttrList for now, and delete it to avoid leak.





More information about the cfe-commits mailing list