[cfe-commits] r61114 - in /cfe/trunk: include/clang/AST/Attr.h include/clang/Basic/DiagnosticKinds.def include/clang/Parse/Action.h include/clang/Parse/AttributeList.h lib/Parse/AttributeList.cpp lib/Parse/ParseObjc.cpp lib/Sema/Sema.h lib/Sema/S

fjahanian fjahanian at apple.com
Sun Dec 28 14:12:44 PST 2008


On Dec 28, 2008, at 7:26 AM, Daniel Dunbar wrote:

> Fariborz,
>
> On Tue, Dec 16, 2008 at 5:07 PM, Fariborz Jahanian  
> <fjahanian at apple.com> wrote:
>> +
>> +  bool hasKind(Kind kind) const {
>> +    return AttrKind == kind;
>> +  }
>
> I don't really see the need for this method (vs getKind() ==) but I
> think it would be more consistent to name it isKind() if you think we
> need it.

Not really needed. It was added in the heat of battle :). Will use  
getKind().

- fariborz

>
>  - Daniel




More information about the cfe-commits mailing list