[cfe-commits] r61430 - in /cfe/trunk: include/clang/Basic/TokenKinds.def lib/Lex/Preprocessor.cpp lib/Parse/ParseDecl.cpp test/Parser/MicrosoftExtensions.c

steve naroff snaroff at apple.com
Thu Dec 25 06:51:27 PST 2008


Hi Anton,

On Dec 25, 2008, at 9:36 AM, Anton Korobeynikov wrote:
>
> Thus I think these keywords are really bogus.

I couldn't agree more! I much preferred the previous preprocessor  
hack...

This was necessary to integrate with VC++. If we weren't integrating  
clang to work with VC++, they wouldn't be necessary (we would simply  
use the GCC __attribute__ mechanism, as you suggest). Here's why they  
needed to be added...

We have some clients using clang to rewrite code on Windows (which  
includes preprocessing).

The previous implementation would remove these MS-specific keywords.

This implementation allows them to pass through (so VC++ can see them).

snaroff

>
> -- 
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State  
> University




More information about the cfe-commits mailing list