[cfe-commits] r60998 - in /cfe/trunk/lib/CodeGen: CGObjC.cpp CGStmt.cpp CodeGenFunction.h

Daniel Dunbar daniel at zuster.org
Mon Dec 15 09:25:23 PST 2008

On Sat, Dec 13, 2008 at 2:52 PM, Anders Carlsson <andersca at mac.com> wrote:
> Author: andersca
> Date: Sat Dec 13 16:52:24 2008
> New Revision: 60998
> URL: http://llvm.org/viewvc/llvm-project?rev=60998&view=rev
> Log:
> Store the size of the EH stack inside each BreakContinue struct so we know when a break/continue won't cross a try block.

Ok, but this is only a solution to one particular case, and I don't
think we need this code once the general case is solved (the case this
is solving should just fall out). The problem is just to know how many
levels of the exception stack we need to pop when we see the
break/continue. If this best solution to this is to merge the
BreakContinue and ObjCEH stacks, we  should just go ahead and do this
(with an eye to making sure it doesn't negatively impact the
performance of code which doesn't use ObjC exceptions).

 - Daniel

More information about the cfe-commits mailing list