[cfe-commits] r61007 - /cfe/trunk/lib/AST/DeclarationName.cpp

Nuno Lopes nunoplopes at sapo.pt
Sun Dec 14 13:56:00 PST 2008


>> Author: nlopes
>> Date: Sun Dec 14 11:27:25 2008
>> New Revision: 61007
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=61007&view=rev
>> Log:
>> fix leakage of CXXSpecialName objects in DeclarationNameTable
>
> Thanks Nuno!  Please don't call set->end() every time through the loop 
> though.  :)  Something like this should work:
>
> for (llvm::FoldingSetIterator<CXXSpecialName> I = set->begin(), E = 
> set->end(); I != E; ++I)
>   ..

Ok, I've commited a fix. Thanks for the review!
Btw, the SemaCXX/constructor.cpp test exposes a double-free bug in the code 
for destruction of C++ decls.

Nuno 




More information about the cfe-commits mailing list