[cfe-commits] r60935 - /cfe/trunk/lib/AST/Expr.cpp

[Chris Lattner]

Author: lattner
Date: Fri Dec 12 00:57:03 2008
New Revision: 60935

URL: http://llvm.org/viewvc/llvm-project?rev=60935&view=rev
Log:
add a fixme.

Modified:
    cfe/trunk/lib/AST/Expr.cpp

Modified: cfe/trunk/lib/AST/Expr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/Expr.cpp?rev=60935&r1=60934&r2=60935&view=diff

==============================================================================
--- cfe/trunk/lib/AST/Expr.cpp (original)
+++ cfe/trunk/lib/AST/Expr.cpp Fri Dec 12 00:57:03 2008
@@ -1029,6 +1029,10 @@
     // If the condition (ignoring parens) is a __builtin_constant_p call, 
     // then only the true side is actually considered in an integer constant
     // expression.  This is an important GNU extension.
+    //
+    // FIXME: ?: with a conditional expr should arguably be an i-c-e if the true
+    // side can be folded in any way to a constant.  See GCC PR38377 for
+    // discussion.
     if (const CallExpr *CallCE = dyn_cast<CallExpr>(Cond->IgnoreParenCasts()))
       if (CallCE->isBuiltinCall() == Builtin::BI__builtin_constant_p)
         FalseExp = 0;