[cfe-commits] r60359 - in /cfe/trunk: include/clang/Basic/DiagnosticKinds.def lib/Parse/ParseDeclCXX.cpp test/SemaCXX/ms-exception-spec.cpp

[Chris Lattner]

On Dec 1, 2008, at 10:00 AM, Douglas Gregor wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=60359&view=rev
> Log:
> Parse the exception-specification throw(...), a Microsoft extension

Cool.

>
> +  // Parse throw(...), a Microsoft extension that means "this  
> function
> +  // can throw anything".
> +  if (Tok.is(tok::ellipsis)) {
> +    SourceLocation EllipsisLoc = ConsumeToken();
> +    if (!getLang().Microsoft)
> +      Diag(EllipsisLoc, diag::ext_ellipsis_exception_spec);
> +    SourceLocation RParenLoc = MatchRHSPunctuation(tok::r_paren,  
> LParenLoc);

I think that this should unconditionally emit the extension warning  
(and let the diagnostics machinery filter it if appropriate).  When - 
fms-extensions isn't specified, should clang just completely reject  
this?

-Chris