[cfe-commits] r59601 - in /cfe/trunk: include/clang/Analysis/PathSensitive/BugReporter.h include/clang/Basic/Diagnostic.h lib/Basic/Diagnostic.cpp lib/Sema/SemaDeclCXX.cpp

[Douglas Gregor]

On Nov 19, 2008, at 2:32 AM, Chris Lattner wrote:
> Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclCXX.cpp?rev=59601&r1=59600&r2=59601&view=diff
>
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- cfe/trunk/lib/Sema/SemaDeclCXX.cpp (original)
> +++ cfe/trunk/lib/Sema/SemaDeclCXX.cpp Wed Nov 19 01:32:16 2008
> @@ -234,7 +234,7 @@
>       if (Param->getIdentifier())
>         Diag(Param->getLocation(),
>              diag::err_param_default_argument_missing_name)
> -          << Param->getIdentifier()->getName();
> +          << Param->getIdentifier();
>       else
>         Diag(Param->getLocation(),
>              diag::err_param_default_argument_missing);


This makes me wonder... should we have an operator<<(DiagnosticInfo,  
NamedDecl*) to output the name of a declaration? It would use  
NamedDecl::getName() rather than NamedDecl::getIdentifier(), so it  
would work with all kinds of names.

	- Doug