[cfe-commits] r59185 - in /cfe/trunk: include/clang/Lex/Lexer.h lib/Lex/PreprocessorLexer.cpp

[Chris Lattner]

On Nov 12, 2008, at 2:43 PM, Ted Kremenek wrote:

> Author: kremenek
> Date: Wed Nov 12 16:43:05 2008
> New Revision: 59185
>
> URL: http://llvm.org/viewvc/llvm-project?rev=59185&view=rev
> Log:
> Move LexIncludeFilename from Lexer to PreprocessorLexer.
> PreprocessorLexer now has a virtual method "IndirectLex" which  
> allows it to call the lex method of its subclasses.  This is not for  
> performance intensive operations.

This is something we should talk about.  I don't think it is right for  
the PTHLexer to deal with angled strings.  I think the PTH producer  
should recognize when an angled string is needed, and encode the token  
as an angled string.  This means that the PTH lexer would just ignore  
the state of the ParsingFilename flag.

-Chris