[cfe-commits] r59404 - /cfe/trunk/lib/CodeGen/CGExprScalar.cpp
Chris Lattner
sabre at nondot.org
Sat Nov 15 22:16:27 PST 2008
Author: lattner
Date: Sun Nov 16 00:16:27 2008
New Revision: 59404
URL: http://llvm.org/viewvc/llvm-project?rev=59404&view=rev
Log:
daniel prefers completed thoughts.
Modified:
cfe/trunk/lib/CodeGen/CGExprScalar.cpp
Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=59404&r1=59403&r2=59404&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGExprScalar.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGExprScalar.cpp Sun Nov 16 00:16:27 2008
@@ -1163,7 +1163,7 @@
// If this is a really simple expression (like x ? 4 : 5), emit this as a
// select instead of as control flow. We can only do this if it is cheap and
- // safe to
+ // safe to evaluate the LHS and RHS unconditionally.
if (E->getLHS() && isCheapEnoughToEvaluateUnconditionally(E->getLHS()) &&
isCheapEnoughToEvaluateUnconditionally(E->getRHS())) {
llvm::Value *CondV = CGF.EvaluateExprAsBool(E->getCond());
More information about the cfe-commits
mailing list