[cfe-commits] r59348 - /cfe/trunk/lib/Analysis/GRExprEngine.cpp

Ted Kremenek kremenek at apple.com
Fri Nov 14 18:35:08 PST 2008


Author: kremenek
Date: Fri Nov 14 20:35:08 2008
New Revision: 59348

URL: http://llvm.org/viewvc/llvm-project?rev=59348&view=rev
Log:
Re-enable an assertion that I mistakenly removed.

Modified:
    cfe/trunk/lib/Analysis/GRExprEngine.cpp

Modified: cfe/trunk/lib/Analysis/GRExprEngine.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/GRExprEngine.cpp?rev=59348&r1=59347&r2=59348&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/GRExprEngine.cpp (original)
+++ cfe/trunk/lib/Analysis/GRExprEngine.cpp Fri Nov 14 20:35:08 2008
@@ -870,13 +870,7 @@
     return;
 
   } else if (const FunctionDecl* FD = dyn_cast<FunctionDecl>(D)) {
-    // FIXME: Does this need to be revised?  We were getting cases in
-    //  real code that did this.
-
-    // FIXME: This is not a valid assertion.  Produce a test case that
-    // refutes it.
-    // assert(asLValue); // Can we assume this?
-
+    assert(asLValue);
     SVal V = loc::FuncVal(FD);
     MakeNode(Dst, Ex, Pred, BindExpr(St, Ex, V));
     return;





More information about the cfe-commits mailing list