[cfe-commits] r59330 - /cfe/trunk/lib/AST/DeclSerialization.cpp

Argiris Kirtzidis akyrtzi at gmail.com
Fri Nov 14 16:24:12 PST 2008

Mike Stump wrote:
> On Nov 14, 2008, at 3:32 PM, Argiris Kirtzidis wrote:
>> -    D.ReadUIntPtr(reinterpret_cast<uintptr_t&>(MDC->SemanticDC), 
>> SemaDCPtrID);
>> -    D.ReadUIntPtr(reinterpret_cast<uintptr_t&>(MDC->LexicalDC), 
>> LexicalDCPtrID);
>> +    D.ReadPtr(MDC->SemanticDC, SemaDCPtrID);
>> +    D.ReadPtr(MDC->LexicalDC, LexicalDCPtrID);
> I like this step forward, but it does mean the bug that still exists 
> is merely hidden a bit harder, and when someone wants to fix it, they 
> won't have the luxury of a diagnostic to tell them they got the fix 
> right.

If there's a bug, it's in Deserializer::ReadPtr which is heavily used 
all over the place; these couple of lines is a drop in the ocean :-)

More information about the cfe-commits mailing list