[cfe-commits] r59232 - /cfe/trunk/lib/Analysis/GRExprEngine.cpp

[Ted Kremenek]

On Nov 12, 2008, at 11:58 PM, Zhongxing Xu wrote:

> Author: zhongxingxu
> Date: Thu Nov 13 01:58:20 2008
> New Revision: 59232
>
> URL: http://llvm.org/viewvc/llvm-project?rev=59232&view=rev
> Log:
> Lift the pointer to alloca'ed region to the pointer to its first  
> element.
> This is required by some operations, e.g., *p = 1; p[0] = 1;.
> Also set the AllocaRegion's type during the cast.
>
> +        // Set the AllocaRegion's type.
> +        const_cast<AllocaRegion*>(AR)->setType(T);

Hi Zhongxing,

I don't think this is the way to go.  MemRegions must be immutable.   
Moreover, this reasoning should not go in GRExprEngine.

Ted
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20081113/85d4f5b8/attachment.html>