[cfe-commits] r59094 - in /cfe/trunk/lib/CodeGen: CGBuilder.h CodeGenFunction.h

[Chris Lattner]

On Nov 11, 2008, at 6:30 PM, Eli Friedman wrote:

> On Tue, Nov 11, 2008 at 4:01 PM, Daniel Dunbar <daniel at zuster.org>  
> wrote:
>> Author: ddunbar
>> Date: Tue Nov 11 18:01:12 2008
>> New Revision: 59094
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=59094&view=rev
>> Log:
>> Disable generation of basic block names in NDEBUG mode.
>>
>> Revert to enabling generation of instruction names when not in NDEBUG
>> mode.
>
> Is this really a good idea?  Normally NDEBUG doesn't change the
> visible behavior of the program.

This also breaks abi compatibility between .o files produced in debug  
and release builds.  I don't know how much that matters in practice.

What case are instruction names useful for?

-Chris