[cfe-commits] r58595 - in /cfe/trunk: include/clang/Analysis/PathSensitive/MemRegion.h lib/Analysis/MemRegion.cpp
Ted Kremenek
kremenek at apple.com
Sun Nov 2 21:35:53 PST 2008
On Nov 2, 2008, at 9:10 PM, Zhongxing Xu wrote:
> I added before to let AnonPointeeRegion to subclass it. Now I find
> AnonPointeeRegion can get its type from its VarDecl, so I removed it
> because it's not used in other places. Feel free to add it when you
> use it.
Sounds completely reasonable! Thanks for cleaning this up!
> I guess in general we should only add regions once we have a
> specific need for them. This actually justifies removing
> AnonTypedRegion (at least for now), but honestly I was just about to
> use it.
>
> We should also probably start putting Store-specific regions in
> BasicStore.cpp. RegionStore.cpp, etc. if we can.
>
> Agree.
Cool.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20081102/19645ccb/attachment.html>
More information about the cfe-commits
mailing list