[cfe-commits] r58501 - in /cfe/trunk: include/clang/Basic/TargetInfo.h lib/Analysis/CFRefCount.cpp lib/Basic/TargetInfo.cpp lib/Basic/Targets.cpp lib/CodeGen/CGDecl.cpp lib/Lex/Preprocessor.cpp lib/Parse/ParseDeclCXX.cpp lib/Sema/SemaDeclCXX.cpp

[Douglas Gregor]

On Oct 31, 2008, at 4:57 PM, Mike Stump wrote:
>> =
>> =====================================================================
>> --- cfe/trunk/lib/Basic/TargetInfo.cpp (original)
>> +++ cfe/trunk/lib/Basic/TargetInfo.cpp Fri Oct 31 04:52:39 2008
>
>>
>> +  WCharType = UnsignedInt;
>
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=58501&r1=58500&r2=58501&view=diff
>> =
>> =====================================================================
>> --- cfe/trunk/lib/Basic/Targets.cpp (original)
>> +++ cfe/trunk/lib/Basic/Targets.cpp Fri Oct 31 04:52:39 2008
>
>>
>> +      WCharType = UnsignedInt;
>
> Hum, in C++, it is a different type, distinct from all other types.  I
> didn't check to see if that is handled someplace else, but, if not, we
> should have a FIXME here saying to do something better for C++.

IIUC, TargetInfo here is telling us what the underlying type of  
wchar_t will be, and unsigned int makes sense there. That wchar_t is a  
unique type is already handled by Clang's type system.

   - Doug