[cfe-commits] r58492 - /cfe/trunk/lib/Analysis/GRExprEngine.cpp
Ted Kremenek
kremenek at apple.com
Fri Oct 31 08:25:23 PDT 2008
On Oct 30, 2008, at 11:05 PM, Zhongxing Xu wrote:
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- cfe/trunk/lib/Analysis/GRExprEngine.cpp (original)
> +++ cfe/trunk/lib/Analysis/GRExprEngine.cpp Fri Oct 31 01:05:32 2008
> @@ -861,10 +861,11 @@
> return;
>
> } else if (const FunctionDecl* FD = dyn_cast<FunctionDecl>(D)) {
> - // We return the loc::FuncVal for an FunctionDecl in both rvalue
> - // and lvalue contexts.
> // FIXME: Does this need to be revised? We were getting cases in
> // real code that did this.
> +
> + assert(asLValue); // Can we assume this?
> +
This can actually happen, so this assertion is invalid. I'll try and
dig up a test case today that exhibits it. For now I'm going to
remove the assertion.
More information about the cfe-commits
mailing list